Fix has_many through association#2478
Closed
jibidus wants to merge 1 commit into
Closed
Conversation
jibidus
force-pushed
the
fix_has_many_through_association
branch
2 times, most recently
from
23984c1 to
df973f8
Compare
jibidus
force-pushed
the
fix_has_many_through_association
branch
from
df973f8 to
1299482
Compare
Member
There was a problem hiding this comment.
Are you sure that above fix is safe also for polymorphic association?
Isn't it safe to just nil-guard null call?
klass.columns_hash[foreign_key.to_s].try(:null)
Contributor
Author
There was a problem hiding this comment.
This may return nil if key does not exist in klass.columns_hash. Perhaps not the return value we expect.
It should be better to write a test with a polymorphic association and see what happen (and fix potential issue), right ?
- Write test with polymorphic association
Contributor
Author
|
Thanks @mshibuya for your work. |
jibidus
pushed a commit
to sogilis/rails_admin
that referenced
this pull request
Nov 26, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
has_manyassociation withthroughissue introduced by #2446.See #2446 for more details.
Issue fixed: #2474