Skip to content

Improve encoding support in CSV converter#2508

Merged
bbenezech merged 1 commit into
railsadminteam:masterfrom
diowa:encoding-fix
Feb 4, 2016
Merged

Improve encoding support in CSV converter#2508
bbenezech merged 1 commit into
railsadminteam:masterfrom
diowa:encoding-fix

Conversation

@tagliala

Copy link
Copy Markdown
Contributor

Fix #2191

⚠️ Merge with extreme care ⚠️

@bbenezech

Copy link
Copy Markdown
Collaborator

Thanks for this.

@tagliala Can I ask you why you need this?
It used to be back in the days some databases where not in utf-8, especially in asia, but I am wondering if it is needed at all today. What are you thoughts on this?

@mshibuya What should we do? utf8 all the things and stop this madness?

@tagliala

tagliala commented Feb 4, 2016

Copy link
Copy Markdown
Contributor Author

I run into the issue at #2191, there was a non-utf8 database whose tables could not be exported

Btw you could also drop the whole thing

@bbenezech

Copy link
Copy Markdown
Collaborator

Ok, I read #2191, it seems a lot of people have this issue.
The code looks nice, let's merge this!

Thanks a lot @tagliala

bbenezech added a commit that referenced this pull request Feb 4, 2016
Improve encoding support in CSV converter
@bbenezech bbenezech merged commit 3fd3b32 into railsadminteam:master Feb 4, 2016
bbenezech added a commit that referenced this pull request Feb 4, 2016
mshibuya added a commit that referenced this pull request Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants