Skip to content

Add SVG file extension to the image detection method#2533

Merged
bbenezech merged 1 commit into
railsadminteam:masterfrom
uiltondutra:field_type_file_upload_detect_svg
Feb 4, 2016
Merged

Add SVG file extension to the image detection method#2533
bbenezech merged 1 commit into
railsadminteam:masterfrom
uiltondutra:field_type_file_upload_detect_svg

Conversation

@uiltondutra

Copy link
Copy Markdown
Contributor

Detect SVG file uploads as images and present them properly on the interface.

@mshibuya

Copy link
Copy Markdown
Member

Test needed!

@bbenezech

Copy link
Copy Markdown
Collaborator

@mshibuya test not really needed, this is just a smart default to show or hide image in the show/list views. Since all browsers can show it, it's good enough I think.

When RailsAdmin was created, SVG wasn't really a thing yet 👴
@uiltondutra thanks

bbenezech added a commit that referenced this pull request Feb 4, 2016
…ct_svg

Add SVG file extension to the image detection method
@bbenezech bbenezech merged commit 1ff702b into railsadminteam:master Feb 4, 2016
@uiltondutra

Copy link
Copy Markdown
Contributor Author

Thanks for the merge @bbenezech. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants