Rename bootstrap-kaminari-views#2651
Merged
bbenezech merged 1 commit intoJun 8, 2016
Merged
Conversation
Collaborator
|
Thanks a lot @benjaminwood ! |
Contributor
Author
|
No problem, thanks for your work and the merge! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2283 for more info.
tl;dr - another gem uses the same kaminari theme name. This causes a conflict in apps that use both gems. This PR renames the kaminari views from twitter-bootstrap to ra-twitter-bootstrap.
Tests pass and I gave it a try in my browser too. Let me know if there is anything else that needs to be done here!