pass parameters to new forms when model is namespaced#2701
Merged
Conversation
fix model.to_param for passing params add tests
loicginoux
changed the title
Member
|
Why is this fix needed? Isn't it enough to pass |
Contributor
Author
|
No it didn't work, I committed a test for this case. |
Contributor
|
@mshibuya i see the same issue. |
Contributor
|
@loicginoux could you rebase these commits in one ? (might this is blocker for merge) |
loicginoux
commented
Feb 11, 2017
|
|
||
| describe 'GET /admin/cms_basic_page/new with parameters for pre-population' do | ||
| it 'populates form field when corresponding parameters are passed in' do | ||
| visit new_path(model_name: 'cms~basic_page', cms_basic_page: {title: 'Hello'}) |
Contributor
Author
There was a problem hiding this comment.
which before block do you mean ? the one in line 20 is not called in this test.
|
I am having the same issues with forms.. Would be great if proposed PR would be merged |
Member
|
Merged in, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When model is namespaced, the prepopulation of the new form via params didn't work.
That should fix it.