Skip to content

Fix #encoding error by oracle_enhanced#2789

Merged
mshibuya merged 1 commit into
railsadminteam:masterfrom
ojiry:support_oracle
Dec 21, 2016
Merged

Fix #encoding error by oracle_enhanced#2789
mshibuya merged 1 commit into
railsadminteam:masterfrom
ojiry:support_oracle

Conversation

@ojiry

@ojiry ojiry commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

An error occurs because Oracle cannot omit FROM.

$ bin/rails c
Loading development environment (Rails 5.0.0.1)
ruby 2.3.3 [1] pry(main)> ::ActiveRecord::Base.connection.select_one("SELECT '' AS str;").values.first.encoding
   (2.4ms)  SELECT '' AS str;
ActiveRecord::StatementInvalid: OCIError: ORA-00911: invalid character: SELECT '' AS str;
from stmt.c:243:in oci8lib_230.bundle

In the case of Oracle, I want to execute the following SQL:

$ bin/rails c
Loading development environment (Rails 5.0.0.1)
ruby 2.3.3 [1] pry(main)> ::ActiveRecord::Base.connection.select_one("SELECT dummy FROM DUAL").values.first.encoding
   (0.9ms)  SELECT dummy FROM DUAL
=> #<Encoding:UTF-8>

ref. https://github.com/rsim/oracle-enhanced

@koic

koic commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

Hi @mshibuya, Thanks for maintenance.

I also want this patch. Is there information necessary for merging?

@mshibuya mshibuya merged commit 34c55b0 into railsadminteam:master Dec 21, 2016
@mshibuya

Copy link
Copy Markdown
Member

Merged in, thanks!

@koic

koic commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

Thanks for your merging 💚 💛 ❤️

@ojiry

ojiry commented Dec 21, 2016

Copy link
Copy Markdown
Contributor Author

Thank you for merged :)

@ojiry ojiry deleted the support_oracle branch December 21, 2016 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants