Skip to content

Loosen the dependency version of Haml#2840

Merged
mshibuya merged 2 commits into
railsadminteam:masterfrom
koic:loosen_dependency_haml
Feb 28, 2017
Merged

Loosen the dependency version of Haml#2840
mshibuya merged 2 commits into
railsadminteam:masterfrom
koic:loosen_dependency_haml

Conversation

@koic

@koic koic commented Feb 27, 2017

Copy link
Copy Markdown
Contributor

Haml 5.0.0.beta.2 is out.

This version will bring 3x rendering speed-up.

And, this PR suppress the following warning associated with upgrading.

Haml::TempleEngine: Option :ugly is invalid

Refer: haml/haml#894

I'd like to use it as soon as possible.

Thanks.

@mshibuya mshibuya merged commit 46cd7ec into railsadminteam:master Feb 28, 2017
@mshibuya

Copy link
Copy Markdown
Member

Thanks!

@koic koic deleted the loosen_dependency_haml branch February 28, 2017 02:06
@koic

koic commented Feb 28, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for your merging! I'm looking forward to the release.

@vincentwoo

Copy link
Copy Markdown
Contributor

Releasing this change becomes a lot more important with the advent of Rails 5.1 and the deprecation of Erubis. The next release of Haml will likely be able to switch to Erubi and thus make rails_admin compatible with Rails 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants