Use data attribute to fetch admin.js options#2870
Merged
mshibuya merged 1 commit intoApr 27, 2017
Merged
Conversation
k0kubun
force-pushed
the
i18n-admin-js-data-attribute
branch
6 times, most recently
from
d69faac to
c6408ac
Compare
k0kubun
force-pushed
the
i18n-admin-js-data-attribute
branch
from
c6408ac to
dc69ca1
Compare
Member
|
Thanks! |
ragesoss
added a commit
to WikiEducationFoundation/WikiEduDashboard
that referenced
this pull request
May 26, 2017
The interpolated Ruby in a Haml :javascript filter now gets HTML escaped, breaking the way it was being used in the shared _head template to pass the set of valid languages and projects. The fix is to pass it as an HTML dataset instead, and pull that into the Javascript afterwards. I followed the example of railsadminteam/rails_admin#2870
|
Thanks, this was a helpful example to follow for a similar problem in my app! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Since Haml 4 doesn't escape interpolated Ruby script, the result of
j I18n.t("admin.js").to_jsonis not HTML-escaped and it's working.Problem
But in Haml 5, such interpolated script is HTML-escaped by default haml/haml#770.
Thus, with Haml 5.0.0.beta.2, it's broken like:
Changes
For security, it'd be good to have it in HTML-escaped form. So, I changed the template to fetch it from data attribute. Using data attribute, we can store JSON object in HTML-escaped form and fetch it safely.