Skip to content

fix HTML of filter refresh on history page#2890

Merged
mshibuya merged 1 commit into
railsadminteam:masterfrom
sethjeffery:fix_history_filter
Jun 9, 2017
Merged

fix HTML of filter refresh on history page#2890
mshibuya merged 1 commit into
railsadminteam:masterfrom
sethjeffery:fix_history_filter

Conversation

@sethjeffery

Copy link
Copy Markdown

Provides a fix for #2889 so that the filter button looks correct again. Same approach as #2706

image

@mshibuya mshibuya merged commit 19a1a5e into railsadminteam:master Jun 9, 2017
@mshibuya

mshibuya commented Jun 9, 2017

Copy link
Copy Markdown
Member

Thanks!

@jschwindt

Copy link
Copy Markdown

I have this error again in version 2.0 with Rails 6.0
Screen Shot 2019-09-13 at 16 34 30
and the solution was to exchange single with double quotes in data-disable-with that contains html tags as shown in my PR.

jschwindt added a commit to jschwindt/rails_admin that referenced this pull request Jan 13, 2021
jschwindt added a commit to jschwindt/rails_admin that referenced this pull request Jan 13, 2021
* v202: (46 commits)
  Fix railsadminteam#2890
  Test against Rails 6.1
  Fix Coveralls flag name
  Make Coveralls functional under GitHub Actions
  Add rspec-retry to mitigate random spec failure
  CI against ActiveRecord adapters properly
  Migrate to GitHub Actions, thanks Travis-CI!
  Use raw_connection to retrieve encoding for mysql2 client
  CI: Update to JRuby 9.2.13.0
  Hide association input for deeply nested fields
  Remove non working link
  refactoring the field_wrapper_for
  add the spec of field_wrapper_for
  fix the indent of hidden field in create and edit actions
  CI: Update to JRuby 9.2.11.0
  Version 2.0.2
  Fix XSS vulnerability in nested forms
  Fix Rubocop offense
  Remove not using of yell_for_non_accessible_fields
  Add 'Reset Filters' translation to I18n
  ...
jschwindt added a commit to jschwindt/rails_admin that referenced this pull request Jan 13, 2021
jschwindt added a commit to jschwindt/rails_admin that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants