Skip to content

use value instead url in file's link_to body #2983

Closed
buncis wants to merge 1 commit into
railsadminteam:masterfrom
buncis:better-file-link-to
Closed

use value instead url in file's link_to body #2983
buncis wants to merge 1 commit into
railsadminteam:masterfrom
buncis:better-file-link-to

Conversation

@buncis

@buncis buncis commented Jan 18, 2018

Copy link
Copy Markdown
Contributor

use filename/value instead full url in file's link_to body

@mshibuya

mshibuya commented May 4, 2018

Copy link
Copy Markdown
Member

Could you write a spec for this?

@buncis

buncis commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

@mshibuya I want to write the spec, but I don't know how since it have no spec before, can you guide me how to write the spec? thank you

  describe '#pretty_value' do
    it 'use value instead url for link_to body' do
      expect().to eq value
    end
  end

@mshibuya

Copy link
Copy Markdown
Member

Cherry-picked as e3770ba.

@mshibuya mshibuya closed this Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants