Add config.horizontal_scroll_list to enable horizontal scrolling colu…#3017
Conversation
bcfb492 to
a03b4b4
Compare
|
Hi @mshibuya, I've created this PR due to interest from Issue #2272 and I've updated the wiki https://github.com/sferik/rails_admin/wiki/Horizontally-scrolling-table-with-frozen-columns-in-list-view to describe it. Hopefully this can make it into a release. The current Travis failures seem unrelated to this PR - "unable to load puma" on other test cases. |
mshibuya
left a comment
There was a problem hiding this comment.
Great work, but there's a few things to consider.
|
Thanks for your feedback!
I hope to put some time into this in a few days. Thanks again! |
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
a03b4b4 to
d511913
Compare
…to globally; Move config logic out of view
|
Hi @mshibuya, I've refactored this code to address your requests
I've reworked the tests to account for these changes, and created new tests to check the model-level configuration. I've also rebased this PR. I can squash these commits if you'd like but I thought I'd leave them separate for now for you to review the changes from the original PR. Let me know if other changes are needed. I don't really know how to fix the codeclimate "cognitive complexity" issue - perhaps split it up into multiple methods, but that seems like it could result in a fair amount of duplicate code. Thanks! |
|
Hi @mshibuya , I was wondering if you could take a look at this, as it's been open for a while. Thanks! |
|
Thanks you for amazing work! |
|
Hi @mshibuya, thanks for getting this merged! Are you planning on making a release soon? It would be great! |
…mns and frozen row headers instead of paginated sets
Addresses Issue #2272.