Fix export crash for models with JSON field#3056
Closed
blaze182 wants to merge 4 commits into
Closed
Conversation
9c26555 to
8291903
Compare
Failed examples:
rspec
./spec/integration/basic/export/rails_admin_basic_export_spec.rb:31 #
RailsAdmin Export POST /admin/players/export (prompt) allows to export
to CSV with associations and default schema, containing properly
translated header and follow configuration
Failure/Error: bindings[:view].content_tag(:pre) { formatted_value
}.html_safe
NoMethodError:
undefined method `content_tag' for nil:NilClass
./lib/rails_admin/config/fields/types/json.rb:17:in `block in
<class:Json>'
rspec ./spec/rails_admin/adapters/active_record_spec.rb:117 # RailsAdmin::Adapters::ActiveRecord data access methods #all supports querying Failure/Error: value.present? ? JSON.parse(value) : nil JSON::ParserError: 765: unexpected token at 'Player 211' ./lib/rails_admin/config/fields/types/json.rb:25
8291903 to
5660134
Compare
mshibuya
added a commit
that referenced
this pull request
Aug 19, 2018
Member
|
Thanks for the PR, fix for But for the change in |
Contributor
Author
|
@mshibuya you can try adding json field to Player model and running specs, it will fail on existing query spec. Same happens in query user interface for any model containing json field, it unexpectedly crashes and needs an explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I experienced a crash when was exporting a model with a JSON field:
Failing lines:
Apparently
bindings[:view]is nil within export context.Here's a proposed fix for that, I specified an
export_valuefor json field.Additionally, another test failed for model querying if JSON field is included, so I suppose it's more practical to return nil instead of raising JSON::ParserError in this case.
Thanks for an awesome product!