Fix wrong styles when using multiple instances of CodeMirror#3107
Merged
mshibuya merged 1 commit intoFeb 9, 2019
Conversation
mshibuya
reviewed
Feb 9, 2019
| @@ -240,6 +240,7 @@ $(document).on 'rails_admin.dom_ready', (e, content) -> | |||
| options = $(this).data('options') | |||
Member
There was a problem hiding this comment.
This line seems to be no longer necessary, right?
Member
There was a problem hiding this comment.
Ah forget it, it is passed to $.getScript
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I faced with a problem when I have multiple CodeMirror instances on a single page. The problem is that the only last style will be applied to all CodeMirror instances.
For example, I have two fields and I wish to write ruby code in the first and javascript in the second:
But as a result for both fields were applied javascript mode + material theme.
I guess that it's a typical javascript async error when variable was redefined before success callback was executed. This is why my short fix gets options directly from dom element in the callback.