Fix Rubocop violations#3256
Closed
nard-tech wants to merge 76 commits into
Closed
Conversation
Contributor
Author
|
@mshibuya Travis CI failed in Ruby version 2.2 due to SyntaxError like this: Safe navigation operator with Which is the best way to resolve this error?
|
Contributor
|
I would vote to drop support for Ruby 2.2 from RailsAdmin |
Member
|
In the next major release of RailsAdmin I will drop support for Ruby older than 2.5.0. Please hold on until 3.0.0 development is ready. |
Member
|
The master branch is ready, can you rebase this to it? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3221, Travis CI failed due to Rubocop offenses.
In addition, violations ignored by
.rubocop_todo.ymlhave been left alone long time.I fixed these violations mainly using
rubocop -a.