Skip to content

Remove unnecessary Devise patch#3352

Merged
mshibuya merged 1 commit into
railsadminteam:masterfrom
codealchemy:remove-devise-patch
Apr 3, 2021
Merged

Remove unnecessary Devise patch#3352
mshibuya merged 1 commit into
railsadminteam:masterfrom
codealchemy:remove-devise-patch

Conversation

@codealchemy

Copy link
Copy Markdown
Contributor

Originally added in db06979, this matches what's upstream in Devise (which was added in heartcombo/devise@17ec0c0) so this patch appears to no longer be needed.

@codealchemy

codealchemy commented Apr 2, 2021

Copy link
Copy Markdown
Contributor Author

Ruby 2.2 / Rails 5 failures appear to be from recent mimemagic updates (unrelated to this change, and happening on master as well).

@mshibuya mshibuya merged commit 8a0e25d into railsadminteam:master Apr 3, 2021
@mshibuya

mshibuya commented Apr 3, 2021

Copy link
Copy Markdown
Member

Agreed, thanks!

@codealchemy codealchemy deleted the remove-devise-patch branch April 5, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants