Remove support for EOL Ruby 2.5#3430
Merged
Merged
Conversation
Ruby 2.5 went EOL 2021-03-31. It is no longer supported upstream and so is not receiving bug fixes, including for security issues. Reduce the testing resources on RailsAdmin. https://www.ruby-lang.org/en/downloads/branches/ Dropping EOL Ruby versions allows the project to begin taking advantage of newer syntax and library features. TargetRubyVersion was removed from .rubocop.yml as this value is determined automatically from the gemspec.
Pull Request Test Coverage Report for Build 1512935100
💛 - Coveralls |
|
Changes unknown |
Member
|
Though being not documented yet (when this discussion is settled I will do it soon), existing way of deciding supported version is:
How do you think of keeping this approach or do you have a different opinion?
I really, really understand this point, but we need to think about existing users who can't upgrade their app easily. |
Member
|
Merging in, since I realized that to introduce Turbo Drive we need to drop support for Ruby 2.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 went EOL 2021-03-31. It is no longer supported upstream and so
is not receiving bug fixes, including for security issues. Reduce the
testing resources on RailsAdmin.
https://www.ruby-lang.org/en/downloads/branches/
Dropping EOL Ruby versions allows the project to begin taking advantage
of newer syntax and library features.
TargetRubyVersion was removed from .rubocop.yml as this value is
determined automatically from the gemspec.