Remove JavaScript library jquery-pjax#3435
Closed
jdufresne wants to merge 1 commit into
Closed
Conversation
The library is no longer maintained and has not received a new release since May 20, 2017. See https://github.com/defunkt/jquery-pjax > Status of this project > > jquery-pjax is largely unmaintained at this point. This also removes the Ruby gem rack-pjax which is also no longer maintained and has not received a new release since Mar 24, 2019. This is work towards the goal of dropping jQuery in favor of more vanilla JavaScript solutions. As a dependency using jQuery, pjax was a barrier toward this goal. jquery-pjax was originally introduced in 645d678 (Nov 16, 2011). Presumably as a page loading optimization, however it is not strictly necessary to achieve the set of RailsAdmin features. After many years of improvements in browser caching, loading, and JavaScript evaluation it is unclear if this optimization is still necessary for a good UX. Refs railsadminteam#2893
Pull Request Test Coverage Report for Build 1514239307
💛 - Coveralls |
|
Changes unknown |
Member
This is understandable, but I'm not totally sure about it. It would be ideal if we can perform quantitative comparison... Another solution will be migrating to Turbo Drive, which I understand is modernized version of Pjax. |
mshibuya
added a commit
that referenced
this pull request
Jan 16, 2022
* Remove JavaScript library jquery-pjax The library is no longer maintained and has not received a new release since May 20, 2017. See https://github.com/defunkt/jquery-pjax > Status of this project > > jquery-pjax is largely unmaintained at this point. This also removes the Ruby gem rack-pjax which is also no longer maintained and has not received a new release since Mar 24, 2019. This is work towards the goal of dropping jQuery in favor of more vanilla JavaScript solutions. As a dependency using jQuery, pjax was a barrier toward this goal. jquery-pjax was originally introduced in 645d678 (Nov 16, 2011). Presumably as a page loading optimization, however it is not strictly necessary to achieve the set of RailsAdmin features. After many years of improvements in browser caching, loading, and JavaScript evaluation it is unclear if this optimization is still necessary for a good UX. Refs #2893
Member
|
Squash-merged with 44451f2, thanks! I'll try introducing Turbo Drive later. |
Member
|
@jdufresne Sorry I failed to put your credit to the commit when I handled squash merge locally. |
Member
Author
|
No worries at all. Thanks for merging and for Rails admin in general! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library is no longer maintained and has not received a new release
since May 20, 2017. See https://github.com/defunkt/jquery-pjax
This also removes the Ruby gem rack-pjax which is also no longer
maintained and has not received a new release since Mar 24, 2019.
This is work towards the goal of dropping jQuery in favor of more
vanilla JavaScript solutions. As a dependency using jQuery, pjax was a
barrier toward this goal.
jquery-pjax was originally introduced in
645d678 (Nov 16, 2011). Presumably as a
page loading optimization, however it is not strictly necessary to
achieve the set of RailsAdmin features. After many years of improvements
in browser caching, loading, and JavaScript evaluation it is unclear if
this optimization is still necessary for a good UX.
Refs #2893