Skip to content

Enable frozen string literals across the project#3483

Merged
codealchemy merged 1 commit into
railsadminteam:masterfrom
jdufresne:frozen-string
Feb 27, 2022
Merged

Enable frozen string literals across the project#3483
codealchemy merged 1 commit into
railsadminteam:masterfrom
jdufresne:frozen-string

Conversation

@jdufresne

Copy link
Copy Markdown
Member

https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcomment

This feature is designed to help transition from mutable string literals
to frozen string literals. The "frozen_string_literal: true" magic
comment was added to the top of all files to enable frozen string
literals. Frozen string literals may be default in future Ruby. Using
frozen string literals is good practice and easier to reason about.

https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcomment

This feature is designed to help transition from mutable string literals
to frozen string literals. The "frozen_string_literal: true" magic
comment was added to the top of all files to enable frozen string
literals. Frozen string literals may be default in future Ruby. Using
frozen string literals is good practice and easier to reason about.
@coveralls

coveralls commented Feb 27, 2022

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.804% when pulling 4effb5f on jdufresne:frozen-string into a95b177 on railsadminteam:master.

@codealchemy codealchemy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@codealchemy codealchemy merged commit 94e599b into railsadminteam:master Feb 27, 2022
@jdufresne jdufresne deleted the frozen-string branch November 5, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants