Skip to content

Tweak select form fields class for filters#3559

Merged
mshibuya merged 1 commit into
railsadminteam:masterfrom
codealchemy:fix-select-for-filters
Oct 28, 2022
Merged

Tweak select form fields class for filters#3559
mshibuya merged 1 commit into
railsadminteam:masterfrom
codealchemy:fix-select-for-filters

Conversation

@codealchemy

Copy link
Copy Markdown
Contributor

Bootstrap 5 uses form-select (https://getbootstrap.com/docs/5.0/forms/select/) to help indicate the field is a dropdown.

Before

Capture d’écran 2022-10-27 à 13 54 24

After

Capture d’écran 2022-10-27 à 13 54 35

Bootstrap 5 uses `form-select` (https://getbootstrap.com/docs/5.0/forms/select/) to help indicate the field is a dropdown.
@coveralls

coveralls commented Oct 27, 2022

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 95.886% when pulling 85fe568 on codealchemy:fix-select-for-filters into 6042110 on railsadminteam:master.

@mshibuya mshibuya merged commit 4a8cc9e into railsadminteam:master Oct 28, 2022
@mshibuya

Copy link
Copy Markdown
Member

It looks better, thanks! 👍

jklimke pushed a commit to 3dcl/rails_admin that referenced this pull request Nov 8, 2022
* master:
  Version 3.1.0
  Fix to use defer instead of async to ensure script loading order
  Tweak `select` form fields class (railsadminteam#3559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants