Restore caching in RailsAdmin::Config::Model#excluded?#3587
Merged
Conversation
|
Changes unknown |
Member
|
Can this behavior tested in the spec, so we don't accidentally disable it again? |
codealchemy
approved these changes
Jan 9, 2023
Partially reverts 2fa86c3. The commit introduced a regression such that RailsAdmin::Config::Model#excluded? stopped caching false values.
jdufresne
force-pushed
the
restore-caching
branch
from
0935915 to
856758a
Compare
Member
Author
|
@mshibuya Good call. Amended an existing test in the latest push that demonstrates the caching. |
Member
|
Thank you 👍 |
jklimke
added a commit
to 3dcl/rails_admin
that referenced
this pull request
Jun 27, 2023
* 'master' of github.com:railsadminteam/rails_admin: (53 commits) fix is_blank and is_present filters for uuid columns (railsadminteam#3629) Add support for '%-l' option to Flatpickr. (railsadminteam#3616) Fix polymorphic association target classes not set correctly in subclasses Fix multiple_carrierwave field spec failing due to mocking Fix webpacker build Relax Rubocop Metrics/ClassLength threshold Version 3.1.2 Postpone introduction of the new event name `rails_admin:dom_ready` Fix install failing with importmap setup Fix to show non-eager-loaded models which are explicitly configured Change dom_ready event name to use colon as the separator Restore caching in RailsAdmin::Config::Model#excluded? (railsadminteam#3587) Update GitHub Actions Badge URL Optimize file path to class name conversion (railsadminteam#3589) Switch to the safe navigation operator in spec files (railsadminteam#3588) Fix typo: Envinronment ==> Environment (railsadminteam#3586) Enable RuboCop Style/Encoding and apply auto-fixes (railsadminteam#3585) Add CI testing for Ruby 3.2 (railsadminteam#3583) Version 3.1.1 Fix some typos (railsadminteam#3580) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially reverts 2fa86c3. The commit introduced a regression such that RailsAdmin::Config::Model#excluded? stopped caching false values.