fix images detection issues for file_upload types#3633
Closed
Laith-jalal wants to merge 1 commit into
Closed
Conversation
Member
|
Thank you for the PR, but the issue was fixed a bit differently: 35c8702 |
|
Changes unknown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue for the
FileUploadtype especially for the:image?instance_option,some file uploading Gems add a query string part to the file/image URL,
paperclipfor example adds timestamp value to the file's URL and in the current implementation having query string will result in NOT considering the file as an image even when it's an image