Skip to content

fix images detection issues for file_upload types#3633

Closed
Laith-jalal wants to merge 1 commit into
railsadminteam:masterfrom
Laith-jalal:fix_file_upload_images_detection_issue
Closed

fix images detection issues for file_upload types#3633
Laith-jalal wants to merge 1 commit into
railsadminteam:masterfrom
Laith-jalal:fix_file_upload_images_detection_issue

Conversation

@Laith-jalal

@Laith-jalal Laith-jalal commented Jun 22, 2023

Copy link
Copy Markdown

This PR fixes an issue for the FileUpload type especially for the :image? instance_option,
some file uploading Gems add a query string part to the file/image URL, paperclip for example adds timestamp value to the file's URL and in the current implementation having query string will result in NOT considering the file as an image even when it's an image

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 95.866% (+0.001%) from 95.865% when pulling d209b87 on Laith-jalal:fix_file_upload_images_detection_issue into 647347c on railsadminteam:master.

@mshibuya mshibuya closed this in 35c8702 Aug 25, 2024
@mshibuya

Copy link
Copy Markdown
Member

Thank you for the PR, but the issue was fixed a bit differently: 35c8702

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes unknown
when pulling d209b87 on Laith-jalal:fix_file_upload_images_detection_issue
into ** on railsadminteam:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants