Show a thumbnail of all representable Active Storage files + images#3656
Merged
mshibuya merged 4 commits intoAug 25, 2024
Merged
Conversation
42b2c0c to
5096a4e
Compare
Contributor
Author
|
|
7477489 to
1246376
Compare
Member
|
Tests are required, but I can handle that. Thank you. |
mshibuya
added a commit
that referenced
this pull request
Aug 25, 2024
- Do not abbreviate 'representation' - Add specs
Contributor
Author
|
Thank you, also for the last bits! |
mshibuya
added a commit
that referenced
this pull request
Aug 25, 2024
- Do not abbreviate 'representation' - Add specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only images have a preview when using Active Storage attachments. Preview of videos (and potentially other file formats) are supported, however, but one needs to use representable instead of only previewable. This PR switches to using representable.
Tested with movie previews and images on multiple upload.
Note that we still need to look at the image mime-type, to show e.g. SVG images (which are not representable, but can still be shown directly - great that there is an automated test for this).
See also: