Skip to content

Allow turbo-rails 2 in gemspec#3671

Merged
mshibuya merged 1 commit into
railsadminteam:masterfrom
bb:patch-1
Feb 12, 2024
Merged

Allow turbo-rails 2 in gemspec#3671
mshibuya merged 1 commit into
railsadminteam:masterfrom
bb:patch-1

Conversation

@bb

@bb bb commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 95.9%. remained the same
when pulling f6c4523 on bb:patch-1
into af7414a on railsadminteam:master.

@mshibuya mshibuya merged commit d520219 into railsadminteam:master Feb 12, 2024
@mshibuya

Copy link
Copy Markdown
Member

CI is failing, but I can handle it. Thanks!

@bb bb deleted the patch-1 branch February 12, 2024 10:18
@bb

bb commented Feb 12, 2024

Copy link
Copy Markdown
Contributor Author

Thank you!

@xijo

xijo commented Jun 28, 2024

Copy link
Copy Markdown

@pathakh any chance to release this soon-ish? Feels bad to force us all to stay on an outdated version of turbo :|

@bb

bb commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

@mshibuya thanks for providing the hotfixes 3.1.3+4. Are there any plans to create a new minor release from master (which includes this PR)?

If not, could you please update the patch version in master to 3.1.4 so we can refer to master in our bundle without having to ignore GHSA-8qgm-g2vv-vwvc in our audits.

@mshibuya

Copy link
Copy Markdown
Member

I've just released a pre-release version 3.2.0.beta. The master was also bumped to that version.
It'll take some more time for the next minor release, but please give feedback so it can happen earlier 🙏

@bb

bb commented Jul 13, 2024

Copy link
Copy Markdown
Contributor Author

That's great, thank you! I tried 3.2.0.beta locally and in CI. Also converted an App from Sprockets to Ruby-Vite (thanks to #3643) which also works for me. Good to go, from my perspective. 🚀

Edit: there are some SASS deprecation warnings inside node_modules/bootstrap/scss/. Not a show-stopper but maybe good to know. They're addressed here: twbs/bootstrap#40623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants