Tidy up trailing whitespace in gem post_install_message#3689
Merged
mshibuya merged 1 commit intoJun 16, 2024
Merged
Conversation
Previously, the post_install_message contained trailing whitespace on
its last line such that the user's console prompt would be shifted to
the right in an unusual way.
Now, follow shell conventions and finish the message with the a final
newline and nothing else.
This change also left aligns the message like other Ruby gem
post_install_messages do.
Before:
```
$ bundle install
...
Post-install message from rails_admin:
### Upgrading RailsAdmin from 2.x.x to 3.x.x ###
Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed.
Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app.
For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md
jon@localhost$
```
After:
```
\### Upgrading RailsAdmin from 2.x.x to 3.x.x ###
Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed.
Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app.
For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md
Successfully installed rails_admin-3.1.2
jon@localhost$
```
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the post_install_message contained trailing whitespace on its last line such that the user's console prompt would be shifted to the right in an unusual way.
Now, follow shell conventions and finish the message with the a final newline and nothing else.
This change also left aligns the message like other Ruby gem post_install_messages do.
Before:
After: