Only enable wasmbind feature of chrono on wasm32 target#345
Open
phoebehfharris wants to merge 1 commit intoramosbugs:mainfrom
Open
Only enable wasmbind feature of chrono on wasm32 target#345phoebehfharris wants to merge 1 commit intoramosbugs:mainfrom
phoebehfharris wants to merge 1 commit intoramosbugs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently trying to package clifton, an authentication manager used by my university's supercomputing system, for Fedora. The Fedora package for chrono doesn't enable the wasmbind feature, understandably, since the repos will never build for wasm.
Packaging clifton requires packaging oauth2-rs, as it is preferred Fedora policy to independently package crates rather than vendor them, but oauth2 requiring chrono's wasmbind feature clashes with the Fedora package's flags.
It doesn't seem like there's much reason for enabling wasmbind as a feature when we're not targeting WebAssembly, so I believe we can make this conditional.
What's the pathway for testing WebAssembly code? All unit tests pass for my target (x86_64 Linux), but I'm not sure how to test the unit tests for a WebAssembly target (I can't imagine they'd fail?)