Add an index of serial numbers to X509_CRL for fast lookups#5511
Merged
Add an index of serial numbers to X509_CRL for fast lookups#5511
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves X509_CRL::is_revoked() performance by building and caching an index of revoked certificate serial numbers inside the CRL’s decoded state, avoiding repeated linear scans over CRL entries during revocation checks.
Changes:
- Add a cached serial-number index (
m_revoked_serials) toCRL_Data. - Build the index during CRL construction and after decoding (
update_index()). - Replace the linear scan in
X509_CRL::is_revoked()with a set membership check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.