Open
Conversation
randombit
force-pushed
the
jack/fix-rollup
branch
from
2b32f15 to
a1d2050
Compare
Sadly SHA-1 seems to be still quite common in this ecosystem.
This would later cause an exception but one rather more opauqe as to the source, so just reject it right away.
This would accept invalid inputs and then fail in more opaque ways later.
This is only used for TLS session data so not likely to occur in practice.
Fixes Limbo rfc5280::nc::permitted-self-issued which was marked xfail
…xcluded name If the SAN is a wildcard, and that wildcard could match some specific excluded name, then the certificate could be used to match against the excluded name, and so should be rejected. RFC 5280 is somewhere between ambigous and silent about this situation.
Since the multiplication occurs against the base point this can only happen if the caller passed zero as the scalar.
The code poisoned the buffer then loaded the input into it, which would cause valgrind to treat the data as initialized.
Would cause incorrect MAC to be computed with probability ~1/2**85.
randombit
force-pushed
the
jack/fix-rollup
branch
from
a1d2050 to
c99f6dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.