Remove deprecated headers by aamijar · Pull Request #2939 · rapidsai/raft

aamijar · 2026-02-03T06:49:06Z

Depends on rapidsai/cuvs#1763. Resolves #2937

This PR does the following:

Removes files with the following message

#ifndef RAFT_HIDE_DEPRECATION_WARNINGS
#pragma message(__FILE__                                                  \
                " is deprecated and will be removed in a future release." \
                " Please use the raft/sparse/solver version instead.")
#endif

Removes files with the following message

/**
 * This file is deprecated and will be removed in a future release.
 */

Pulls from correct non-deprecated headers like usingraft/util/cudart_utils.cuh instead of raft/core/cudart_utils.cuh
Pulls correct functionality from non-deprecated headers like using raft/linalg/matrix_vector.cuh instead of raft/matrix/math.cuh. This requires using the newer mdspan based apis.
Consolidates gemm.cuh and gemm.hpp into just gemm.cuh

Update:
There were a couple of fixes included in this PR that I have decoupled. Instead those fixes should be merged in #2940.
This will allow us to unravel the merging sequence better to avoid breaking changes altogether. Still marking this PR as breaking for awareness purposes.
After merging #2940, the cuml side and cuvs side can be updated to use the non-deprecated apis. Then we can merge this raft PR to remove the deprecated and unused headers.

Update:
There are a couple of breaking changes that affect cugraph and cuopt, so we will need to merge fixes for those first.

Merging sequence:
#2940 -> rapidsai/cuvs#1763 -> rapidsai/cuml#7752 -> rapidsai/cuml#7797 -> rapidsai/cugraph#5429 -> NVIDIA/cuopt#865 -> #2939

Downstream libraries CI status:
cuvs: 🟢
cuml: 🟢
cugraph: 🟢
cuopt: 🟢

bdice

Approving CMake changes.

Prepares for rapidsai/raft#2939. This PR updates the following headers: | old | new | |-----|-----| | `#include <raft/core/cudart_utils.hpp>` | `#include <raft/util/cudart_utils.hpp>` | | `#include <raft/common/nvtx.hpp>` | `#include <raft/core/nvtx.hpp>` | | `#include <raft/sparse/linalg/masked_matmul.hpp>` | `#include <raft/sparse/linalg/masked_matmul.cuh>` | | `#include <raft/linalg/gemm.hpp>` | `#include <raft/linalg/gemm.cuh>` | | `#include <raft/sparse/mst/mst.cuh>` | `#include <raft/sparse/solver/mst.cuh>` | Authors: - Anupam (https://github.com/aamijar) Approvers: - Jinsol Park (https://github.com/jinsolp) - Corey J. Nolet (https://github.com/cjnolet) URL: #1763

Prepares for rapidsai/raft#2939. This PR updates the following headers: | old | new | |-----|-----| | `#include <raft/core/cudart_utils.hpp>` | `#include <raft/util/cudart_utils.hpp>` | | `#include <raft/common/nvtx.hpp>` | `#include <raft/core/nvtx.hpp>` | | `#include <raft/sparse/linalg/masked_matmul.hpp>` | `#include <raft/sparse/linalg/masked_matmul.cuh>` | | `#include <raft/linalg/gemm.hpp>` | `#include <raft/linalg/gemm.cuh>` | | `#include <raft/sparse/mst/mst.cuh>` | `#include <raft/sparse/solver/mst.cuh>` | Authors: - Anupam (https://github.com/aamijar) Approvers: - Jinsol Park (https://github.com/jinsolp) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1763

cjnolet · 2026-02-13T13:13:38Z

I know this change might seem harmless but let's make sure we test downstream libraries before we merge it.

dantegd

Just had a comment, leaving a request for change just while we hear about testing downstream dependencies as @cjnolet suggested, would be nice to avoid CI breakages :)

dantegd · 2026-02-13T15:36:03Z

cpp/include/raft/sparse/solver/detail/lanczos.cuh

 #include <raft/matrix/diagonal.cuh>
 #include <raft/matrix/gather.cuh>
-#include <raft/matrix/matrix.cuh>
+// include <raft/matrix/matrix.cuh>


Need to remove the commented include?

done in f8d851e!

dantegd · 2026-02-13T15:37:24Z

cpp/include/raft/matrix/ratio.cuh

+void ratio(raft::resources const& handle,
+           raft::device_vector_view<const math_t, idx_t> src,
+           raft::device_vector_view<math_t, idx_t> dest)


Nice update to the API :)

aamijar · 2026-02-13T17:30:39Z

Just had a comment, leaving a request for change just while we hear about testing downstream dependencies as @cjnolet suggested, would be nice to avoid CI breakages :)

Testing CI on all downstream repos now

aamijar · 2026-02-13T23:00:50Z

Glad I tested CI for cugraph and cuopt too, since those are breaking with this change!

(cugraph) https://github.com/rapidsai/cugraph/actions/runs/21995874700/job/63555618060?pr=5429#step:9:4440
(cuopt) https://github.com/NVIDIA/cuopt/actions/runs/21996113135/job/63556997488?pr=865#step:13:1421

Testing with rapidsai/raft#2939 and adding fixes. ## Summary by CodeRabbit * **Chores** * Unified include paths for RAFT NVTX and cuSPARSE headers across the codebase. * Bumped header copyright years to 2026. * **Tests** * Updated test files to use the new RAFT header paths. Authors: - Anupam (https://github.com/aamijar) Approvers: - Hugo Linsenmaier (https://github.com/hlinsen) URL: #865

Testing with rapidsai/raft#2939 and adding fixes. Authors: - Anupam (https://github.com/aamijar) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Seunghwa Kang (https://github.com/seunghwak) URL: #5429

aamijar · 2026-02-23T21:00:30Z

@dantegd, could you resolve your request for changes if everything has been resolved.
The last downstream PR (cugraph) has been merged now so we should be good to merge this PR.

aamijar · 2026-02-23T23:29:28Z

/merge

Merges Remove deprecated headers (rapidsai#2939). Conflict resolutions: - rsvd.cuh: Use new mdspan-based raft::matrix::sqrt and reciprocal APIs (they have internal dry-run guards); kept cudaMemsetAsync guard - svd.cuh: Use raft::matrix::weighted_sqrt (has internal dry-run guard) - matrix.cuh: Accept deletion (deprecated, removed in main) Co-authored-by: Cursor <cursoragent@cursor.com>

raft-deprecated-headers

8276a46

aamijar requested review from a team as code owners February 3, 2026 06:49

github-project-automation bot added this to Unstructured Data Processing Feb 3, 2026

aamijar self-assigned this Feb 3, 2026

aamijar added breaking Breaking change improvement Improvement / enhancement to an existing function labels Feb 3, 2026

aamijar changed the title ~~raft-deprecated-headers~~ Remove deprecated headers Feb 3, 2026

This was referenced Feb 3, 2026

Update raft headers rapidsai/cuvs#1763

Merged

Update raft headers rapidsai/cuml#7752

Merged

aamijar and others added 2 commits February 3, 2026 07:19

remove raft.hpp

7480a3a

Merge branch 'main' into raft-deprecated-headers

d7ca157

aamijar added Public API Affects cuML PR or issue affects downstream cuML Affects cuVS PR or issue affects downstream cuVS labels Feb 3, 2026

include comms.hpp

dde196c

aamijar moved this to In Progress in Unstructured Data Processing Feb 3, 2026

bdice approved these changes Feb 3, 2026

View reviewed changes

Merge branch 'main' into raft-deprecated-headers

d64f2f0

divyegala approved these changes Feb 13, 2026

View reviewed changes

dantegd requested changes Feb 13, 2026

View reviewed changes

aamijar and others added 2 commits February 13, 2026 17:00

removed commented include

f8d851e

Merge branch 'main' into raft-deprecated-headers

0debc49

This was referenced Feb 13, 2026

Test CI with raft #2939 rapidsai/cuvs#1803

Closed

Test CI with raft #2939 rapidsai/cuml#7799

Closed

Update raft headers rapidsai/cugraph#5429

Merged

Update raft headers NVIDIA/cuopt#865

Merged

aamijar added Affects cuGraph PR or issue affects downstream cuGraph Affects cuOpt labels Feb 13, 2026

aamijar added 2 commits February 13, 2026 23:56

remove unused

43bda46

fix weighted_sqrt

29bba0c

Merge branch 'main' into raft-deprecated-headers

3f1ae01

dantegd approved these changes Feb 23, 2026

View reviewed changes

rapids-bot bot merged commit bda45d1 into rapidsai:main Feb 23, 2026
77 checks passed

github-project-automation bot moved this from In Progress to Done in Unstructured Data Processing Feb 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated headers#2939

Remove deprecated headers#2939
rapids-bot[bot] merged 10 commits intorapidsai:mainfrom
aamijar:raft-deprecated-headers

aamijar commented Feb 3, 2026 •

edited

Loading

Uh oh!

bdice left a comment

Uh oh!

cjnolet commented Feb 13, 2026

Uh oh!

dantegd left a comment

Uh oh!

dantegd Feb 13, 2026

Uh oh!

aamijar Feb 13, 2026

Uh oh!

dantegd Feb 13, 2026

Uh oh!

aamijar commented Feb 13, 2026

Uh oh!

aamijar commented Feb 13, 2026

Uh oh!

aamijar commented Feb 23, 2026

Uh oh!

aamijar commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

aamijar commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdice left a comment

Choose a reason for hiding this comment

Uh oh!

cjnolet commented Feb 13, 2026

Uh oh!

dantegd left a comment

Choose a reason for hiding this comment

Uh oh!

dantegd Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

aamijar Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

dantegd Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

aamijar commented Feb 13, 2026

Uh oh!

aamijar commented Feb 13, 2026

Uh oh!

aamijar commented Feb 23, 2026

Uh oh!

aamijar commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aamijar commented Feb 3, 2026 •

edited

Loading