Conversation
- Increase the stack size to 16kb - Enable tracing for stack overflows - Copy the file to workspace root (to respect it always)
This is needed for enabling the optimizations for the demos Plus I don't think it would hurt
orhun
force-pushed
the
refactor/improve-esp32-std-demo
branch
from
2ffea37 to
1e91b4a
Compare
j-g00da
approved these changes
Jan 31, 2026
Member
j-g00da
left a comment
j-g00da
left a comment
There was a problem hiding this comment.
Looks good, please flash a board to make sure this works properly (sadly the CI only checks if it compiles)
Member
Author
|
Yup it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is split into commits for easier review:
I tried to add enough context to each commit message to make it clear what was changed and why.
We could squash the commits when merging.