feat(backend): make "underline-color" feature optional#166
Merged
orhun merged 6 commits intoratatui:mainfrom Feb 14, 2026
Merged
feat(backend): make "underline-color" feature optional#166orhun merged 6 commits intoratatui:mainfrom
orhun merged 6 commits intoratatui:mainfrom
Conversation
orhun
reviewed
Feb 14, 2026
Member
orhun
left a comment
orhun
left a comment
There was a problem hiding this comment.
Let's make it opt-in, that's also what we are doing in ratatui-core
I believe users could enable this if they need it. The performance benefit is more important here than shipping this with many features imo
Co-authored-by: Orhun Parmaksız <[email protected]>
Member
|
Can you also update |
orhun
approved these changes
Feb 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR makes the
underline-colorfeature optional. when disabled, 8 bytes are recouped per terminal cell (4 bytes per cell in ratatui's twoVec<Cell>terminal buffers). this also helps somewhat with the limited bandwidth on targeted hardware.currently,
underline-coloris enabled by default since i didn't want to start off with a breaking change, but i propose to make it opt-in instead, as it's only a breaking change if you're already using the feature, plus the memory savings from not enabling it warrants the opt-in setup (as this could otherwise go unnoticed).