Skip to content

feat(extras): create mousefood-extras#185

Open
sermuns wants to merge 9 commits intoratatui:mainfrom
sermuns:mousefood-extras
Open

feat(extras): create mousefood-extras#185
sermuns wants to merge 9 commits intoratatui:mainfrom
sermuns:mousefood-extras

Conversation

@sermuns
Copy link
Copy Markdown
Contributor

@sermuns sermuns commented Mar 24, 2026

Closes #183.

There are 3 // TODO: comments I would like help with:

Comment on lines +3 to +4
# TODO:
# description = "???"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to

description = "Widgets for mousefood logo"

Comment on lines +12 to +15
# TODO: these fields??
# keywords = ["embedded-graphics", "ratatui", "tui"]
# categories = ["embedded"]
# exclude = ["/.github", "/assets"]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relates to embedded-graphics only by-proxy. I would add "mousefood" to keywords instead.
Also no-std in both keywords and categories.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed exclude, and changed it to this:

keywords = ["mousefood", "ratatui", "tui"]
categories = ["no-std", "graphics"]

@sermuns sermuns marked this pull request as ready for review March 24, 2026 19:34
Copy link
Copy Markdown
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Can you also check the CI if we are running the build/tests for this new crate?

Copy link
Copy Markdown
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sermuns
Copy link
Copy Markdown
Contributor Author

sermuns commented Mar 31, 2026

Looking great!

Can you also check the CI if we are running the build/tests for this new crate?

No, it doesn't seem to be included. I think we can fix this by adding --workspace to

$ cargo test --locked --lib --all-features

@sermuns
Copy link
Copy Markdown
Contributor Author

sermuns commented Mar 31, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mousefood logo widget

3 participants