feat(simulator)!: remove simulator feature#83
Merged
j-g00da merged 1 commit intoratatui:mainfrom Jun 22, 2025
Merged
Conversation
j-g00da
reviewed
Jun 19, 2025
Member
|
Rebase the branch, markdownlint ci didn't work, it's fixed now. |
j-g00da
changed the title
deadbaed
force-pushed
the
simulator_example
branch
from
07e6918 to
2ed04eb
Compare
Contributor
Author
|
A 80 columns limit in a readme file seems a bit extreme for me, but i'll fix that. |
deadbaed
force-pushed
the
simulator_example
branch
from
2ed04eb to
9222503
Compare
Member
|
Yeah, that's the default setting, I would change it to 100 |
j-g00da
reviewed
Jun 19, 2025
Member
j-g00da
left a comment
j-g00da
left a comment
There was a problem hiding this comment.
Left some nitpick comments, but generally LGTM.
deadbaed
force-pushed
the
simulator_example
branch
from
9222503 to
ac3b8bb
Compare
Contributor
Author
|
Whoops, I'm too used of having |
deadbaed
force-pushed
the
simulator_example
branch
from
ac3b8bb to
64bec4b
Compare
- moved simulator from mousefood/examples to examples/simulator - removed `simulator` feature - ci: run `fmt` and `clippy` on all workspace crates
deadbaed
force-pushed
the
simulator_example
branch
from
64bec4b to
1d2610f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completely supersedes #67.
simulatorfeaturefmtandclippyon all workspace crates