feat(core): add distinctUntilChanged operator#58
feat(core): add distinctUntilChanged operator#58tamazlykar wants to merge 1 commit intoraveclassic:masterfrom
Conversation
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit f687137. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
|
Hey @tamazlykar, what is the reasoning behind adding this operator? |
|
Ok, I see you need deep comparison due to different object literals (different references) even their contents are the same. Well, I can't say such things are in the spirit of frp-ts as the intention is clearly to set the new reference and deep comparison looks like a "fix" for that. Instead I'd suggest moving the comparison out of the const a = newAtom({ name: 'foo' })
a.set({ name: 'foo' }) // the intention is to push new object
if (!deepEqual(a.get(), {name: 'foo'})) { // the intention is to check deeply
a.set({ name: 'foo' })
} |
|
ok found the original issue, linking #59 |
No description provided.