models: replace workflow.run_number with generation and restart number#205
Merged
mdonadoni merged 1 commit intoreanahub:masterfrom Nov 15, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 74.24% 74.44% +0.20%
==========================================
Files 7 7
Lines 893 900 +7
==========================================
+ Hits 663 670 +7
Misses 230 230
|
mdonadoni
reviewed
Oct 9, 2023
mdonadoni
reviewed
Oct 11, 2023
ef5f9d4 to
5a14407
Compare
tiborsimko
reviewed
Oct 12, 2023
d6eeafe to
79f8221
Compare
mdonadoni
reviewed
Oct 27, 2023
58fa915 to
850065f
Compare
mdonadoni
approved these changes
Nov 1, 2023
Member
mdonadoni
left a comment
There was a problem hiding this comment.
Amazing job! Everything works well 🚀
Change the workflow table to split the run_number into two integers: one is the major run number (the number before the dot), and the other one is the minor run number (after the dot), which increases when restarting a workflow, thus removing the limit of 9 restarts. Closes reanahub#186.
850065f to
589978b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the workflow table to split the run_number into two integers: one referring to the generation of the workflows, and the other one referring to the restart number, thus removing the limit of 9 restarts.
Closes #186.
To test the PR, these quick scripts might be come in handy:
1) a certain number of times (default15)../restart.sh 50 3will restartroot6-roofit.350 times.