Skip to content

refactor(secrets): adapt to reana-commons secret-handling changes (#583)#583

Merged
tiborsimko merged 1 commit intoreanahub:masterfrom
mdonadoni:secrets-refactor
Aug 21, 2024
Merged

refactor(secrets): adapt to reana-commons secret-handling changes (#583)#583
tiborsimko merged 1 commit intoreanahub:masterfrom
mdonadoni:secrets-refactor

Conversation

@mdonadoni
Copy link
Copy Markdown
Member

mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request May 6, 2024
@mdonadoni mdonadoni force-pushed the secrets-refactor branch from 82afe28 to e4c00d3 Compare May 6, 2024 14:40
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request May 6, 2024
@mdonadoni mdonadoni force-pushed the secrets-refactor branch from e4c00d3 to 39d460c Compare May 6, 2024 14:42
@mdonadoni
Copy link
Copy Markdown
Member Author

mdonadoni commented May 6, 2024

TODO:

mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request May 6, 2024
@mdonadoni mdonadoni force-pushed the secrets-refactor branch from 39d460c to dc94f04 Compare May 6, 2024 15:11
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 8, 2024
@mdonadoni mdonadoni marked this pull request as ready for review August 8, 2024 13:37
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 19, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 19, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.13%. Comparing base (fb9923c) to head (d9512fb).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
reana_workflow_controller/rest/utils.py 16.66% 5 Missing ⚠️
reana_workflow_controller/consumer.py 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   74.28%   75.13%   +0.85%     
==========================================
  Files          15       15              
  Lines        1466     1476      +10     
==========================================
+ Hits         1089     1109      +20     
+ Misses        377      367      -10     
Files with missing lines Coverage Δ
reana_workflow_controller/k8s.py 88.97% <100.00%> (ø)
reana_workflow_controller/workflow_run_manager.py 81.27% <100.00%> (+0.08%) ⬆️
reana_workflow_controller/consumer.py 55.84% <90.00%> (+10.57%) ⬆️
reana_workflow_controller/rest/utils.py 81.06% <16.66%> (-0.73%) ⬇️
---- 🚨 Try these New Features:

@tiborsimko tiborsimko merged commit d9512fb into reanahub:master Aug 21, 2024
@mdonadoni mdonadoni deleted the secrets-refactor branch December 5, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

secrets: avoid repeated calls to k8s API

2 participants