feat(helm): allow cluster administrator to configure ingress host (#804)#804
Conversation
| - name: REANA_DEFAULT_QUOTA_DISK_LIMIT | ||
| value: {{ .Values.quota.default_disk_limit | default 0 | quote }} | ||
| {{- if .Values.quota.enabled }} | ||
| - name: REANA_INGRESS_HOST |
There was a problem hiding this comment.
The REANA_INGRESS_HOST should not be located inside the "if quota..." clause, because it does not depend on quotas. Please move it above, next to where REANA_INGRESS_ANNOTATIONS lives.
| # Accessing the cluster from outside world | ||
| ingress: | ||
| enabled: true | ||
| host: "" |
There was a problem hiding this comment.
Hmm, do we need to add a new field ingress.host for this functionality? I'm wondering because we already have reana_hostname field defined elsewhere, so if people set it up, we could perhaps reuse that directly. (And if it is not set up, then use the empty string as default value.)
(Another possibility would be to hardcode "" as default value inside helm/reana/templates/reana-workflow-controller.yaml, without even playing with reana_hostname. )
In this way we don't need to introduce the new ingress.host field.... Thinking of making changes to 0.9.3 as minimal as possible.
Alputer
force-pushed
the
ingress-host-customization
branch
from
1cde2e5 to
1479730
Compare
tiborsimko
left a comment
tiborsimko
left a comment
There was a problem hiding this comment.
Works nicely locally and on DEV 👍
* feat(helm): allow cluster administrator to configure ingress host (reanahub#804)
* feat(helm): allow cluster administrator to configure ingress host (reanahub#804)
feat(helm): allow cluster administrator to configure ingress host (reanahub#804)
2 participants
Closes reanahub/reana-workflow-controller#587