feat(helm): add configurable workspace listing limits#900
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
=======================================
Coverage 29.86% 29.86%
=======================================
Files 26 26
Lines 2823 2823
=======================================
Hits 843 843
Misses 1980 1980 🚀 New features to boost your workflow:
|
…#900) Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
2dcf76e to
736ed9f
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
736ed9f to
56ffec7
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
56ffec7 to
b7a3759
Compare
| REANA_OPENSEARCH_USE_SSL: true | ||
| REANA_OPENSEARCH_CA_CERTS: "/code/certs/ca.crt" | ||
| REANA_OPENSEARCH_USER: reana | ||
| WORKSPACE_DISPLAY_FILE_LIMIT: 100000 |
There was a problem hiding this comment.
Shall we document the new environment variables in README.md as part of this PR? Or shall we do it later as part of #901?
There was a problem hiding this comment.
Let's do it now so that we don't forget about it :)
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
b7a3759 to
2f3ec4c
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
2f3ec4c to
4a67098
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
4a67098 to
df9a8b5
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
df9a8b5 to
6c2c01d
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
401fcdd to
6cd96cc
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
6cd96cc to
df9813c
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
df9813c to
f38e835
Compare
Set default values for FORCE_GARBAGE_COLLECTION and WORKSPACE_DISPLAY_FILE_LIMIT environment variables in Helm.
f38e835 to
35b905d
Compare
Set default values for WORKSPACE_DISPLAY_FILE_LIMIT and FORCE_GARBAGE_COLLECTION in the Helm chart for reana-workflow-controller. Closes reanahub/reana-workflow-controller#644
35b905d to
ee64327
Compare
| REANA_OPENSEARCH_CA_CERTS: "/code/certs/ca.crt" | ||
| REANA_OPENSEARCH_USER: reana | ||
| WORKSPACE_DISPLAY_FILE_LIMIT: 100000 | ||
| FORCE_GARBAGE_COLLECTION: "" |
There was a problem hiding this comment.
FORCE_GARBAGE_COLLECTION can be removed from values.yaml since reana-workflow-controller already defaults to "" when the env var is not set:
_gc_env = os.getenv("FORCE_GARBAGE_COLLECTION", "")The README documentation added in this PR is sufficient for discoverability.
(Same applies to REANA_QUOTA_MANAGEMENT_SECRET which could be cleaned up separately — reana-server already defaults to "" in its config.py.)
| REANA_OPENSEARCH_USE_SSL: true | ||
| REANA_OPENSEARCH_CA_CERTS: "/code/certs/ca.crt" | ||
| REANA_OPENSEARCH_USER: reana | ||
| WORKSPACE_DISPLAY_FILE_LIMIT: 100000 |
There was a problem hiding this comment.
Same for WORKSPACE_DISPLAY_FILE_LIMIT — reana-workflow-controller already defaults to 100000 in its config.py:
WORKSPACE_DISPLAY_FILE_LIMIT = int(os.getenv("WORKSPACE_DISPLAY_FILE_LIMIT", "100000"))So this line can be removed from values.yaml as well, keeping only the README documentation.
|
Nit: consider rewording the commit message for release notes readability. The current headline "add workspace listing defaults" is a bit vague. Suggestion: |
Add WORKSPACE_DISPLAY_FILE_LIMIT and FORCE_GARBAGE_COLLECTION environment variables for reana-workflow-controller to the Helm chart README. Closes reanahub/reana-workflow-controller#644
ee64327 to
1694191
Compare
Add WORKSPACE_DISPLAY_FILE_LIMIT and FORCE_GARBAGE_COLLECTION environment variables for reana-workflow-controller to the Helm chart README. Closes reanahub/reana-workflow-controller#644
1694191 to
cdcaa96
Compare
Add WORKSPACE_DISPLAY_FILE_LIMIT and FORCE_GARBAGE_COLLECTION
environment variables for reana-workflow-controller to the
Helm chart README.
Closes reanahub/reana-workflow-controller#644