Fix version check for python 3.10+#562
Merged
douglasmiller merged 1 commit intoMay 25, 2022
Merged
Conversation
douglasmiller
approved these changes
May 25, 2022
douglasmiller
left a comment
douglasmiller
left a comment
Contributor
There was a problem hiding this comment.
👍🏼 Thank you for identifying and fixing this issue, @dgilmanAIDENTIFIED!
argo-recurly
pushed a commit
that referenced
this pull request
May 25, 2022
[Full Changelog](4.16.0...4.16.1) **Merged Pull Requests** - Fix version check for python 3.10+ [#562](#562) ([dgilmanAIDENTIFIED](https://github.com/dgilmanAIDENTIFIED))
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a major regression in Python 3.10+. The version check was doing string comparisons and reverting to old parsing styles. This meant that an otherwise unchanged update from Python 3.9 to Python 3.10 would have recurly emit datetime objects without the timezone, which creates consistent errors on everything that works with the recurly datetime objects as python carefully asserts when you try to use or compare naive with localized datetimes.