Skip to content

Allow detecting comments from other bots#29

Merged
dkwon17 merged 1 commit intoredhat-actions:mainfrom
dkwon17:allow-other-bots
Apr 3, 2023
Merged

Allow detecting comments from other bots#29
dkwon17 merged 1 commit intoredhat-actions:mainfrom
dkwon17:allow-other-bots

Conversation

@dkwon17
Copy link
Copy Markdown
Collaborator

@dkwon17 dkwon17 commented Apr 3, 2023

Description

Currently, the GitHub action tries to update an existing badge comment:
image
only if it was created by the github-actions bot.

However, there are other cases where the comment is made by a different bot:
image

This PR checks for existing badge comments by any bot, instead of only the github-actions bot.

Related Issue(s)

N/A

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

  • Action does not check if existing comment is made by the github-actions bot
  • Update tests

Testing this PR

The comment updating can be tested by making a PR against this repo: https://github.com/dkwon17/my-repo
After making the PR, to test that existing functionality is not affected, update the PR branch, and verify that no new comment is added

@github-actions github-actions bot added the CRDA Scan Approved CRDA scan approved by a collaborator label Apr 3, 2023
@dkwon17 dkwon17 changed the title Allow updating comments from other bots Allow detecting comments from other bots Apr 3, 2023
Signed-off-by: David Kwon <dakwon@redhat.com>
@github-actions github-actions bot added the CRDA Scan Passed CRDA found no vulnerabilities label Apr 3, 2023
@dkwon17 dkwon17 force-pushed the allow-other-bots branch from 4783370 to 24d8f87 Compare April 3, 2023 15:07
@github-actions github-actions bot added CRDA Scan Passed CRDA found no vulnerabilities and removed CRDA Scan Passed CRDA found no vulnerabilities labels Apr 3, 2023
@dkwon17 dkwon17 merged commit cf7e9e5 into redhat-actions:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CRDA Scan Approved CRDA scan approved by a collaborator CRDA Scan Passed CRDA found no vulnerabilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants