Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
RomanNikitenko
left a comment
RomanNikitenko
left a comment
There was a problem hiding this comment.
@sbouchet
thank you for the provided flag - it should really simplify PRs testing!
does it work with forks?
I'm asking because I provided a PR number
it looks like script applied it
but
on the openshift console I see that editor image is default, not from my PR...
|
@sbouchet I'll propose a fix for the corresponding lines, please check it on linux Another place for an improvement - it should not replace target image by |
| curl -sL -o "${TMP_EDITOR_DEF}" "${EDITOR_DEFINITION}" | ||
|
|
||
| # Replace the che-code image with the PR image (only the injector, not the runtime) | ||
| sed -i "s|image: quay.io/che-incubator/che-code:.*|image: ${PR_IMAGE}|" "${TMP_EDITOR_DEF}" |
There was a problem hiding this comment.
this line I've replaced by
sed -i.bak "s|image: quay.io/che-incubator/che-code:.*|image: ${PR_IMAGE}|" "${TMP_EDITOR_DEF}" && rm -f "${TMP_EDITOR_DEF}.bak"
to get it working on macOS
Could you check if it works for linux?
|
|
||
| for devfile_url in "${DEVFILE_URL_LIST[@]}"; do | ||
| curl -sL -o ${TMP_DEVFILE} ${devfile_url} | ||
| sed -i 's/^/ /' ${TMP_DEVFILE} |
There was a problem hiding this comment.
This line I've replaced by
sed 's/^/ /' "${TMP_DEVFILE}" > "${TMP_DEVFILE}.tmp" && mv "${TMP_DEVFILE}.tmp" "${TMP_DEVFILE}"
2 participants
No description provided.