Renamed global preference file to preference.yaml from config.yaml

[girishramnani]

What is the purpose of this change? What does it change?

The global preference's default name changes to preference.yaml instead of config.yaml. As this file is present in the ~/.odo folder it will not colide with the config.yaml if someone chooses to create a component in home dir.

Was the change discussed in an issue?

fixes #1766

How to test changes?

odo preference set Timeout 5 # this should create a ~/.odo/preference.yaml instead of ~/.odo/config.yaml

NOTE - Add this to the ChangeLog as this is a breaking change

[cdrage]

/retest

[cdrage]

This LGTM.

Are there any tests you need to fix?

[girishramnani]

/retest

[girishramnani]

No all the tests should work @cdrage

[cdrage]

/retest

[kadel]

@girishramnani We are not doing ensuring the backward compatibility after all?

[girishramnani]

@kadel according to the discussion in the issue, @jorgemoralespou said that having a changelog entry would be enough

[kadel]

@girishramnani can you please add how will the Release change entry look like?

@kadel according to the discussion in the issue, @jorgemoralespou said that having a changelog entry would be enough

I know, I was saying originally the same :-)
I'm ok with this.
/approve

I'm just making sure that this is what you want to do as you had good arguments why we should try to do it as nonbreaking change.

[kadel]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

/lgtm