fix: pass urlProtocol as query parameter to sucess.html page#1118
Open
dgolovin wants to merge 2 commits intoredhat-developer:mainfrom
Open
fix: pass urlProtocol as query parameter to sucess.html page#1118dgolovin wants to merge 2 commits intoredhat-developer:mainfrom
dgolovin wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
dgolovin
requested review from
axel7083,
benoitf and
feloy
and removed request for
a team
cdrage
requested changes
Apr 15, 2026
Member
cdrage
left a comment
cdrage
left a comment
There was a problem hiding this comment.
we should add fallbacks if env.urlProtocol does not exist if this is extension is installed on a system that does not have it.
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1070 by reading urlProtocol form env.urlProtocol and passing it as a query parameter to success.html page.
It depends on: