fix: add typecheck step to the build to catch compilation errors#1129
Merged
dgolovin merged 1 commit intoredhat-developer:mainfrom Apr 17, 2026
Merged
Conversation
This fix adds typecheck script which runs `tsc --noEmit` to verify there is no compilation errors. This would catch errors if extension's code is using not existing API. Signed-off-by: Denis Golovin <dgolovin@redhat.com>
SoniaSandler
approved these changes
Apr 17, 2026
podman-desktop-triager
bot
added
domain/redhat-account/reviewed
and removed
domain/redhat-account/inreview
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds typecheck script which runs
tsc --noEmitto verify there is no compilation errors. This would catch errors if extension's code is using not existing API.Required for #1070 to catch errors related to usage of not published yet modules of @podman-desktop/api.