Fix cancel support with CompletableFuture compose#679
Merged
datho7561 merged 1 commit intoredhat-developer:masterfrom Jul 28, 2022
Merged
Fix cancel support with CompletableFuture compose#679datho7561 merged 1 commit intoredhat-developer:masterfrom
datho7561 merged 1 commit intoredhat-developer:masterfrom
Conversation
Signed-off-by: azerr <azerr@redhat.com>
Contributor
Author
|
I noticed that all feature (completion, codeAction, hover, etc) which uses
is called,it doesn't throw a CancellationException. I noticed that with code action which can take some time sometimes, so it is hard to reproduce easily. But you can reproduce easily if you:
Without my PR, you will notice that the first call of |
d85d8db to
19c0694
Compare
datho7561
approved these changes
Jul 28, 2022
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Works for me. Good catch! We should probably also copy this over to other language servers.
datho7561
added a commit
to datho7561/lsp4mp
that referenced
this pull request
Jul 29, 2022
This method makes it easier to implement go to definition in properties files. Includes the recent bug fix to the method (see redhat-developer/quarkus-ls#679) Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/lsp4mp
that referenced
this pull request
Jul 29, 2022
This method makes it easier to implement go to definition in properties files. Includes the recent bug fix to the method (see redhat-developer/quarkus-ls#679) Closes eclipse-lsp4mp#257 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/lsp4mp
that referenced
this pull request
Jul 29, 2022
This method makes it easier to implement go to definition in properties files. Includes the recent bug fix to the method (see redhat-developer/quarkus-ls#679) Closes eclipse-lsp4mp#257 Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr
pushed a commit
to eclipse-lsp4mp/lsp4mp
that referenced
this pull request
Aug 16, 2022
This method makes it easier to implement go to definition in properties files. Includes the recent bug fix to the method (see redhat-developer/quarkus-ls#679) Closes #257 Signed-off-by: David Thompson <davthomp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cancel support with CompletableFuture compose
Signed-off-by: azerr azerr@redhat.com