Support surround with section/comments command#801
Merged
angelozerr merged 1 commit intoredhat-developer:masterfrom Mar 2, 2023
Merged
Support surround with section/comments command#801angelozerr merged 1 commit intoredhat-developer:masterfrom
angelozerr merged 1 commit intoredhat-developer:masterfrom
Conversation
JessicaJHee
force-pushed
the
581-surround-with
branch
from
7620aa1 to
2acb633
Compare
angelozerr
reviewed
Feb 23, 2023
angelozerr
reviewed
Feb 23, 2023
angelozerr
reviewed
Feb 23, 2023
angelozerr
reviewed
Feb 23, 2023
angelozerr
reviewed
Feb 23, 2023
angelozerr
reviewed
Feb 23, 2023
| } | ||
| break; | ||
| default: | ||
| List<String> sections = getSectionNames(node, offset, adjusted); |
Contributor
There was a problem hiding this comment.
Indeed it should be really nice to support snippet with section, but let's do that in an another PR, let's generate only for the moment:
- {#}
- {/}
And #802 should takes care of apply completion of section (without snippet)
angelozerr
reviewed
Feb 23, 2023
angelozerr
reviewed
Feb 23, 2023
JessicaJHee
force-pushed
the
581-surround-with
branch
from
2acb633 to
15e2df6
Compare
angelozerr
reviewed
Mar 2, 2023
angelozerr
reviewed
Mar 2, 2023
angelozerr
reviewed
Mar 2, 2023
Contributor
|
@JessicaJHee I think this PR is not a draft PR now? |
angelozerr
reviewed
Mar 2, 2023
Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
581-surround-with
branch
from
15e2df6 to
75fd79d
Compare
Contributor
|
LGTM, thanks @JessicaJHee ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-quarkus#581