Ignore 'UndefinedObject' + 'UndefinedNamespace' problem code action should appear only if LSP client can support update configuration.#862
Conversation
|
This causes the tests to fail, since in the tests we expect the code action to appear, and it doesn't |
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Once the tests are fixed, I think this will be good to merge
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
from
c3fa97b to
3b3f879
Compare
Indeed I need to fix tests. |
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
2 times, most recently
from
3576bda to
105d289
Compare
angelozerr
changed the title
|
@datho7561 tests should be fixed and I missed to do the same thing for UndefinedNamespace. |
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
from
105d289 to
0a70bf1
Compare
|
@datho7561 it seems that there is a problem with snapshot https://github.com/redhat-developer/quarkus-ls/actions/runs/4757288906/jobs/8453919530#step:7:443 |
Right, we need to point to lsp4mp |
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
This PR is good. Thanks, Angelo! I'll raise a quick PR to fix the issue with the snapshots
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
from
0a70bf1 to
048ac03
Compare
should appear only if LSP client can support update configuration. Signed-off-by: azerr <azerr@redhat.com>
3 participants
Ignore 'UndefinedObject' problem code action should appear only if LSP client can support update configuration.
In IJ Quarkus, it doesn't support the capability to update configuration on client side. In otherwise the
Ignore 'UndefinedObject' problemshould not appear:This PR checks that LSP client can support the command which update LSP client settings.