Skip to content

fix: add languageId filter for options similar to microprofile#999

Merged
angelozerr merged 1 commit intoredhat-developer:masterfrom
angelozerr:override_register_options_for_quarkus
Oct 10, 2024
Merged

fix: add languageId filter for options similar to microprofile#999
angelozerr merged 1 commit intoredhat-developer:masterfrom
angelozerr:override_register_options_for_quarkus

Conversation

@angelozerr
Copy link
Copy Markdown
Contributor

fix: add languageId filter for options similar to microprofile

@angelozerr angelozerr added bug Something isn't working quarkus-ls Quarkus Language Server Issue properties Features supported in application.properties labels Oct 9, 2024
@angelozerr angelozerr added this to the 0.20.0 milestone Oct 9, 2024
@angelozerr angelozerr self-assigned this Oct 9, 2024
@angelozerr angelozerr force-pushed the override_register_options_for_quarkus branch 5 times, most recently from b72f33b to d198b4f Compare October 9, 2024 12:46
@angelozerr angelozerr requested a review from datho7561 October 9, 2024 15:06
@datho7561
Copy link
Copy Markdown
Contributor

I don't think that Qute files are working properly. I'll double check on my end though.

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completion, validation, and go to definition aren't working in Qute files

@angelozerr
Copy link
Copy Markdown
Contributor Author

Thanks for your feedback.

Let me investigate the problem.

@angelozerr angelozerr force-pushed the override_register_options_for_quarkus branch from d198b4f to a9f5a3a Compare October 9, 2024 18:54
@angelozerr
Copy link
Copy Markdown
Contributor Author

Completion, validation, and go to definition aren't working in Qute files

My bad, I forgot to push my work. Sorry to have loosed your time -(

Please re-retry it.

@datho7561
Copy link
Copy Markdown
Contributor

datho7561 commented Oct 9, 2024

Most of the features are working now, but I still don't see validation. see below

@datho7561
Copy link
Copy Markdown
Contributor

datho7561 commented Oct 9, 2024

I'm getting textDocument/publishDiagnostics messages from the server, but they are all empty.

This doesn't seem to be related to this PR in particular, I can reproduce this with the latest released version of vscode-quarkus.

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is up with Qute validation in vsocde-quarkus (see #1000). The other features seem to be working and the code seems reasonable. If validation is working in intellij-quarkus, feel free to merge.

@angelozerr
Copy link
Copy Markdown
Contributor Author

Something is up with Qute validation in vsocde-quarkus (see #1000). The other features seem to be working and the code seems reasonable. If validation is working in intellij-quarkus, feel free to merge.

It works for me in vscode-quarkus and my PR should not impact diagnostics. I merge the PR and let's discuss about your problem in the issue that you have created.

Thanks again @datho7561 for your review!

@angelozerr angelozerr merged commit 27c0522 into redhat-developer:master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working properties Features supported in application.properties quarkus-ls Quarkus Language Server Issue

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants