Skip to content

Commit e30e71a

Browse files
authored
chore: use the attribute instead of hardcoding the link for DPDY file in 1.8 (#2062)
* chore: use the attribute instead of hardcoding the link for DPDY file in 1.8 Signed-off-by: Nick Boldt <nboldt@redhat.com> * echo the branch we're using as the source of the ccutil script so we can see why we're using main instead of release-1.y Signed-off-by: Nick Boldt <nboldt@redhat.com> * Apply suggestion from @nickboldt --------- Signed-off-by: Nick Boldt <nboldt@redhat.com>
1 parent 2b773a3 commit e30e71a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/pr.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ concurrency:
3333
group: ${{ github.workflow }}-${{ github.event.number || github.event.pull_request.head.ref }}
3434
cancel-in-progress: true
3535

36-
env:
36+
env:
3737
GH_TEAM: rhdh
3838
GH_ORGANIZATION: redhat-developer
3939
jobs:
@@ -47,7 +47,7 @@ jobs:
4747
uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1
4848
with:
4949
app-id: ${{ secrets.RHDH_GITHUB_APP_ID }}
50-
private-key: ${{ secrets.RHDH_GITHUB_APP_PRIVATE_KEY }}
50+
private-key: ${{ secrets.RHDH_GITHUB_APP_PRIVATE_KEY }}
5151
- name: Check team membership
5252
uses: redhat-developer/rhdh/.github/actions/check-author@main
5353
id: check-team-membership
@@ -104,13 +104,13 @@ jobs:
104104
run: |
105105
# update
106106
sudo apt-get update -y || true
107-
# install
107+
# install
108108
sudo apt-get -y -q install podman && podman --version
109109
echo "GIT_BRANCH=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" >> $GITHUB_ENV
110110
111111
- name: Build guides and indexes
112112
run: |
113-
echo "Building PR ${{ github.event.pull_request.number }}"
113+
echo "Building PR ${{ github.event.pull_request.number }} using scripts from ${{ github.event.pull_request.base.ref }} branch"
114114
cp trusted-scripts/build/scripts/build-ccutil.sh pr-content/build/scripts/build-ccutil.sh
115115
cd pr-content
116116
build/scripts/build-ccutil.sh -b "pr-${{ github.event.number }}"
@@ -140,7 +140,7 @@ jobs:
140140
cd pr-content
141141
gh repo set-default "${ORG_REPO}"
142142
# for a given PR, check for existing comments from rhdh-bot; select the last one (if more than one)
143-
if [[ $(gh api "repos/${ORG_REPO}/issues/${PR_NUM}/comments" -q 'map(select(.user.login=="rhdh-bot"))|last|.id') ]]; then
143+
if [[ $(gh api "repos/${ORG_REPO}/issues/${PR_NUM}/comments" -q 'map(select(.user.login=="rhdh-bot"))|last|.id') ]]; then
144144
# edit that comment:
145145
gh pr comment ${PR_NUM} -R "${ORG_REPO}" --edit-last --body "Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-${PR_NUM}/ @ $(date "+%x %X")"
146146
else

modules/dynamic-plugins/proc-enable-plugins-rhdh-container-image.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ In the {product-very-short} container image, a set of dynamic plugins is preload
88
You can enable and configure the plugins in the {product-very-short} container image, including how to manage the default configuration, set necessary environment variables, and ensure the proper functionality of the plugins within your application.
99

1010
.Prerequisites
11-
* You have access to the link:https://raw.githubusercontent.com/redhat-developer/rhdh/refs/heads/release-1.8/dynamic-plugins.default.yaml[`dynamic-plugins.default.yaml`] file, which lists all preloaded plugins and their default configuration.
11+
* You have access to the link:{dynamic-plugins-default-yaml-link}[`dynamic-plugins.default.yaml`] file, which lists all preloaded plugins and their default configuration.
1212
* You have deployed the {product-very-short} application, and have access to the logs of the `install-dynamic-plugins` init container.
1313
* You have the necessary permissions to modify plugin configurations and access the application environment.
1414
* You have identified and set the required environment variables referenced by the plugin's default configuration. These environment variables must be defined in the Helm Chart or Operator configuration.
1515

1616
.Procedure
1717
. Start your {product-very-short} application and access the logs of the `install-dynamic-plugins` init container within the {product-very-short} pod.
1818
. Identify the {dynamic-plugins-reference-book-link}#red-hat-supported-plugins[Red Hat supported plugins] that are disabled by default.
19-
. Copy the package configuration from the link:https://raw.githubusercontent.com/redhat-developer/rhdh/refs/heads/release-1.8/dynamic-plugins.default.yaml[`dynamic-plugins.default.yaml`] file.
19+
. Copy the package configuration from the link:{dynamic-plugins-default-yaml-link}[`dynamic-plugins.default.yaml`] file.
2020
. Open the plugin configuration file and locate the plugin entry you want to enable.
2121
+
2222
The location of the plugin configuration file varies based on the deployment method. For more details, see {installing-and-viewing-plugins-book-link}[{installing-and-viewing-plugins-book-title}].

0 commit comments

Comments
 (0)