Skip to content

chore: use the attribute instead of hardcoding the link for DPDY file in 1.8#2062

Merged
nickboldt merged 3 commits intorelease-1.8from
use-dpdy-link_18
Apr 17, 2026
Merged

chore: use the attribute instead of hardcoding the link for DPDY file in 1.8#2062
nickboldt merged 3 commits intorelease-1.8from
use-dpdy-link_18

Conversation

@nickboldt
Copy link
Copy Markdown
Member

@nickboldt nickboldt commented Apr 15, 2026

What does this PR do?

chore: use the attribute instead of hardcoding the link for DPDY file in 1.8

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://redhat.atlassian.net/browse/RHIDP-12990

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… in 1.8

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt changed the title chore: use the attribute instead of... chore: use the attribute instead of hardcoding the link for DPDY file in 1.8 Apr 15, 2026
@nickboldt nickboldt added the Technical review done ⛅ Any procedure has been succesfully tested label Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@rhdh-bot rhdh-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 15, 2026

❌ Build failed

The documentation build failed before producing a report.
View full logs | 4/17/2026, 11:10:25 PM

@nickboldt
Copy link
Copy Markdown
Member Author

once #2063 is merged and ported to the 1.8 and 1.9 branches, the html preview should pass (as it won't try to run the CQA check)

…can see why we're using main instead of release-1.y

Signed-off-by: Nick Boldt <nboldt@redhat.com>
Copy link
Copy Markdown
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread .github/workflows/pr.yml Outdated
@openshift-ci openshift-ci bot removed the lgtm label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 17, 2026

New changes are detected. LGTM label has been removed.

@sonarqubecloud
Copy link
Copy Markdown

@nickboldt nickboldt enabled auto-merge (squash) April 17, 2026 23:10
Copy link
Copy Markdown
Collaborator

@rhdh-bot rhdh-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nickboldt nickboldt merged commit e30e71a into release-1.8 Apr 17, 2026
5 of 6 checks passed
@nickboldt nickboldt deleted the use-dpdy-link_18 branch April 17, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants