Skip to content

chore: fix copyrights/exec lines for the various scripts; add one for running the cqa so we can check that locally too#2065

Closed
nickboldt wants to merge 6 commits intomainfrom
better-scripts-for-mac-and-others
Closed

chore: fix copyrights/exec lines for the various scripts; add one for running the cqa so we can check that locally too#2065
nickboldt wants to merge 6 commits intomainfrom
better-scripts-for-mac-and-others

Conversation

@nickboldt
Copy link
Copy Markdown
Member

@nickboldt nickboldt commented Apr 16, 2026

What does this PR do?

chore: fix copyrights/exec lines for the various scripts; add one for running the cqa so we can check that locally too

Signed-off-by: rhdh-bot service account rhdh-bot@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://redhat.atlassian.net/browse/RHIDP-12990

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… running the cqa so we can check that locally too

Signed-off-by: rhdh-bot service account <rhdh-bot@redhat.com>
@nickboldt nickboldt changed the title chore: fix copyrights/exec lines for the... chore: fix copyrights/exec lines for the various scripts; add one for running the cqa so we can check that locally too Apr 16, 2026
@nickboldt nickboldt requested a review from themr0c April 16, 2026 00:18
@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 16, 2026

Shellcheck Analysis Results

Changed shell scripts in this PR: 5

Scripts analyzed:

  • build/scripts/build-ccutil.sh
  • build/scripts/build-cqa.sh
  • build/scripts/build.sh
  • build/scripts/lint-scripts.sh
  • build/scripts/update-cqa-resources.sh

Check the Files changed tab for detailed shellcheck suggestions.

All findings are reported as warnings and won't block the PR.


Automated shellcheck analysis • See shellcheck.net for details

Copy link
Copy Markdown
Collaborator

@rhdh-bot rhdh-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 16, 2026

Content Quality Assessment Results

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail


Automated CQA check run on the entire repository — 2026-04-17 23:17:16 UTC

@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 16, 2026

❌ Build failed

The documentation build failed before producing a report.
View full logs | 4/17/2026, 11:24:23 PM

@openshift-ci openshift-ci bot removed the lgtm label Apr 16, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

New changes are detected. LGTM label has been removed.

Signed-off-by: Nick Boldt <nboldt@redhat.com>
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Comment thread build/scripts/build-ccutil.sh Outdated
@sonarqubecloud
Copy link
Copy Markdown

@nickboldt
Copy link
Copy Markdown
Member Author

replaced by https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/2067/changes so we can validate the html build works after fixing the GH actions.

@nickboldt nickboldt closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants